Ensure blocking mode timer is started even when set via a third-party API call #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… API call Signed-off-by: DL6ER <dl6er@dl6er.de>
PromoFaux
reviewed
Jan 6, 2024
| @@ -97,7 +103,7 @@ function countDown() { | |||
| ena.text("Enable Blocking (" + secondsTimeSpanToHMS(seconds) + ")"); | |||
| } else { | |||
| ena.text("Enable Blocking"); | |||
| piholeChanged("enabled"); | |||
| piholeChanged("enabled", null); | |||
There was a problem hiding this comment.
Nit-picky comment: As timer has a default declaration of null in the parameters for piholeChanged, does null need to be explicitly added to the function call here?
yubiuser
approved these changes
Jan 9, 2024
|
Not needed because defaults are always used when not explicitly specified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
See title. It works by initiating/resetting the timer whenever the API tells us there is a timer. Before, it was only started when the button in the GUI was clicked.
Fixes the issue originally reported in pi-hole/FTL#1845
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.