Use replaceAll to ensure all newlines are converted to HTML line breaks #2931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fix only the first newline of settings descriptions being properly rewritten into a HTML line break. This is implemented by replacing
X.replace() -> X.replaceAll()
and a classical "slip of the pen" bug.Currently, the following setting descriptions are affected by this:
dns.domain
dns.rateLimit.count
webserver.acl
webserver.port
webserver.tls.cert
misc.dnsmasq_lines
Cfm. the effect of this change in the following screenshots (red = newline not replaced, green = newline replaced):
development-v6
branchThis PR
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase
)