-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak main activity graph #2956
Conversation
…ded and other queries. As cache is arguably somehow permitted, too, make the difference between them clear Signed-off-by: DL6ER <dl6er@dl6er.de>
1217404
to
50f28e8
Compare
Signed-off-by: DL6ER <dl6er@dl6er.de>
Signed-off-by: DL6ER <dl6er@dl6er.de>
Has been confirmed working on the related Discourse thread |
Signed-off-by: DL6ER <dl6er@dl6er.de>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I’ve been on this branch for a month or so now. Other than the colors @rdwebdesign wants to fix, it has been running just fine and I haven’t noticed any other issues. Thanks!! |
Note: The code is working. |
Conflicts have been resolved. |
Signed-off-by: DL6ER <dl6er@dl6er.de>
1472432
to
d880a38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on testing used comments
What does this implement/fix?
The permitted column in the main graph was actually the sum of forwarded and other queries. As cache is arguably somehow permitted, too, make the difference between them clear.
Note
Needs pi-hole/FTL#1884 to be checked out
Related issue or feature (if applicable): https://discourse.pi-hole.net/t/dashboard-graphs-dont-match/68263
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.