Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Teleporter file selection on Mac OS #2975

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 6, 2024

What does this implement/fix?

Use MIME type instead of explicit file type endings during the file selection of the Teleporter input field. Even when the latter should be fine according to the standards, Safari (and, in general, any browser on Mac) seems to ignore this and support only mimetype-based selections. This is backed by several similar reports on Stackoverflow over the past couple of years.

I am not convinced this is the best way of implementing this - in particular because we are not in the wrong here - Mac OS is clearly not complying with standards here - and this is a mere compromise to please them.

Related issue or feature (if applicable): See link below.

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…lection of the Teleporter input field. Even when the latter should be fine according to the standards, Safari (and, in general, any browser on Mac) seems to ignore this and support only mimetype-based selections. This is backed by several similar reports on Stackoverflow over the past couple of years.

Signed-off-by: DL6ER <dl6er@dl6er.de>
@DL6ER DL6ER requested a review from a team March 6, 2024 18:19
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a mac to test this against, but still working on Windows so....

@DL6ER DL6ER merged commit 8e24643 into development-v6 Mar 12, 2024
7 checks passed
@DL6ER DL6ER deleted the fix/odd_apple branch March 12, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants