Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add firmware check and message during SSH login #73

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

m-roberts
Copy link
Contributor

@m-roberts m-roberts commented Nov 3, 2022

Closes #72

This PR attempts to add a message during each SSH login showing if there is a firmware update available.

Still need to parse the command output without invoking desktop notifications, evaluate performance and produce a human-friendly message about what to do if there is an update.

@m-roberts m-roberts changed the title Add MOTD check Add firmware check and message during SSH login Nov 3, 2022
@m-roberts
Copy link
Contributor Author

m-roberts commented Nov 4, 2022

Just thinking about setting this update check as permissable for non-root to work with SSH login... I think that the current sudo requirement is because of the fact that this works with notify-send.

Seems we need to split out the desktop notification management into its own daemon that runs as root so that the check (and update?) script can be invoked as a non-root user.

It seems reasonable to either have a flag to determine backend/use-case, or that the desktop notification daemon is only used if it exists with a stdout fallback.

Also, 'check' is an infinite service, not a one-shot as is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add support for headless use-cases
1 participant