Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uploading USB-setup bundle from onboarding #430

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jcapona
Copy link
Contributor

@jcapona jcapona commented Jul 5, 2023

Status Ticket/Issue
Ready Ticket

Main changes

  • Update first page of the onboarding to allow user to select if they're a teacher or a home user.
  • If they're a user, they're prompted to upload a setup-file to configure and update their device.

Also, this new 'selection' page of the onboarding is skipped if we detect that the user is onboarding on the device (using a display and keyboard) or if the pi-top doesn't have an internet connection; in this case, they're redirected to the language page.

Screenshots (feature, test output, profiling, dev tools etc)

image

image

image

Other notes (e.g. implementation quirks, edge cases, questions / issues)

Manual testing tips

Tag anyone who definitely needs to review or help

@jcapona jcapona force-pushed the SWE-170-offline-setup branch 3 times, most recently from 1b3a7c6 to ec61686 Compare July 7, 2023 12:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Patch coverage: 73.43% and project coverage change: +0.10 🎉

Comparison is base (fed230c) 69.16% compared to head (0e0c89d) 69.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   69.16%   69.26%   +0.10%     
==========================================
  Files         182      189       +7     
  Lines        3467     3589     +122     
  Branches      153      173      +20     
==========================================
+ Hits         2398     2486      +88     
- Misses        941      961      +20     
- Partials      128      142      +14     
Flag Coverage Δ
js-tests 75.63% <82.52%> (+0.56%) ⬆️
python-tests 66.15% <36.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frontend/src/Root.tsx 0.00% <ø> (ø)
frontend/src/pages/languagePage/LanguagePage.tsx 80.00% <ø> (ø)
frontend/src/services/postFile.ts 0.00% <0.00%> (ø)
pt_os_web_portal/backend/routes.py 84.86% <27.27%> (-3.16%) ⬇️
frontend/src/components/onboarding_app/App.tsx 89.13% <50.00%> (-1.99%) ⬇️
frontend/src/components/optionCard/OptionCard.tsx 66.66% <66.66%> (ø)
frontend/src/components/upload/Upload.tsx 75.00% <75.00%> (ø)
frontend/src/components/choice/Choice.tsx 80.00% <80.00%> (ø)
...rontend/src/components/upload/utils/fileUpload.tsx 82.75% <82.75%> (ø)
frontend/src/pages/splashPage/SplashPage.tsx 84.21% <83.33%> (-15.79%) ⬇️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jcapona jcapona force-pushed the SWE-170-offline-setup branch 3 times, most recently from c207ac7 to 2957dce Compare July 11, 2023 00:25
@jcapona jcapona marked this pull request as ready for review July 11, 2023 00:31
@jcapona jcapona marked this pull request as draft July 12, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants