Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating nginx configuration for osticket requirements, fixes path_info override through try_files, fixes #9 #10

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sknopp
Copy link
Contributor

@sknopp sknopp commented Oct 10, 2020

as already stated in #9 this fixes nginx path routing issues within ajax.php and fastcgi, so popups and hints are working again

@sknopp
Copy link
Contributor Author

sknopp commented Oct 11, 2020

i needed to further improve the image to get it working with subdirectory url paths.
There is another PR of me ongoing on osTicket itself, which fixes ROOT_PATH not being applied correctly from configuration. It essentially solves this issue of osTicket.

But regardless if it will be accepted or not, the changes here are just the correct counterpart to set the required configurations in osTicket. So no risk to break something.

Last i added an option to set the helpdesk_url setting through docker envs.

I think this will greatly improve the possible usecases of this image in production. 😊

@sknopp sknopp mentioned this pull request Apr 4, 2021
@marlon-sousa
Copy link

Hello,

This PR solved a problem I was having.

If this repo is still alive I really recomend that it is merged.

Otherwise @sknopp are you maintining a up to date version?

@sknopp
Copy link
Contributor Author

sknopp commented Aug 27, 2021

Hey @marlon-sousa

nope i'm not maintaining anything, but there seems not to be much more to do when this PR would be merged.

At least for my instances the project works well since my PR.

Regards 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants