Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-1915: CI Fix #155

Merged
merged 1 commit into from
Jun 13, 2024
Merged

PIA-1915: CI Fix #155

merged 1 commit into from
Jun 13, 2024

Conversation

kp-geneva-parayno
Copy link
Contributor

@kp-geneva-parayno kp-geneva-parayno commented Jun 6, 2024

Summary
Removed parallel running
Removed before and after suite

@kp-geneva-parayno kp-geneva-parayno self-assigned this Jun 6, 2024
@kp-geneva-parayno kp-geneva-parayno marked this pull request as ready for review June 6, 2024 08:34
@kp-geneva-parayno
Copy link
Contributor Author

kp-geneva-parayno commented Jun 6, 2024

testing ios and tvos ci - do not review

@kp-geneva-parayno kp-geneva-parayno changed the title PIA-0000: Remove parallel running PIA-1915: CI Fix Jun 7, 2024
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, I just added one comment on the xctestplan
Once that's addressed, this can be merged
Thank you!

@kp-geneva-parayno kp-geneva-parayno force-pushed the PIA-tvOS_CI_Fix branch 2 times, most recently from bb90ed0 to 160f614 Compare June 13, 2024 01:58
PIA-1915: removed hardcoded credentials
@kp-geneva-parayno
Copy link
Contributor Author

thanks @kp-laura-sempere - updated.
not sure why the tvos unit tests are failing?

Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @kp-geneva-parayno!

@kp-geneva-parayno kp-geneva-parayno merged commit d54e900 into master Jun 13, 2024
2 checks passed
@kp-geneva-parayno kp-geneva-parayno deleted the PIA-tvOS_CI_Fix branch June 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants