-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
normalize Vector with size 1 #97
base: master
Are you sure you want to change the base?
Conversation
1057c5d
to
bc6b3a8
Compare
Do we need to checkout when its size norm2= 0 for this and other normalize? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add to the tests. Could handle divide by zero in a separate PR or here
4db5c44
to
97bacd3
Compare
97bacd3
to
4f6ab50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a check in the unit test?
4f6ab50
to
1a4940a
Compare
LinearAlgebra::Vector<double, 1> vec1 = { 4.7 }; | ||
vec1.normalize(); | ||
EXPECT_DOUBLE_EQ( vec1, 1.0 ); | ||
|
||
// Size 1 vector test. | ||
// FIXME: construction of length 1 vector fails with NVCC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test pass? We commented this out below because of issues with cuda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it passed on V100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the commented code below pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh maybe it's trying to construct from a scalar that fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, commented code also get passed on V100
retest this please. |
eadfa85
to
5b7e844
Compare
No description provided.