migration DDL preview functionality #584
Conversation
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 90.82% 91.21% +0.38%
==========================================
Files 105 105
Lines 7183 7044 -139
==========================================
- Hits 6524 6425 -99
+ Misses 659 619 -40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@AliSayyah This looks great, thanks! It's exactly what I had in mind. |
|
I'll work on more tests, but how do you think we should handle the command? Would this work? |
Yes, I like that 👍 |
|
Hey, @dantownsend. This seems ok to me. But let me know if there are any problems, or the tests are insufficient. |
| await self._run_add_columns(backwards=True) | ||
| await self._run_add_tables(backwards=True) | ||
| await self._run_drop_tables(backwards=True) | ||
| await self._run_rename_tables(backwards=True) | ||
| await self._run_drop_columns(backwards=True) | ||
| await self._run_rename_columns(backwards=True) | ||
| await self._run_alter_columns(backwards=True) |
There was a problem hiding this comment.
It looks good - my only concern was this bit.
You've merged run and run_backwards - I can understand why, as it reduces repetition. The order of the operations were slightly different before when running backwards. Having thought about it though, I think the new order should also be fine.
|
@AliSayyah This looks good to me, thanks. I think we should release it. |
Hey there!
Just some cleanups and initial base stuff.
Doesn't work right now.