Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error check for order_by mixin columns #673

Merged
merged 2 commits into from Nov 10, 2022
Merged

Add error check for order_by mixin columns #673

merged 2 commits into from Nov 10, 2022

Conversation

MiguelGuthridge
Copy link
Contributor

Resolves #672

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #673 (d3261e3) into master (970bef9) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
- Coverage   91.25%   91.24%   -0.02%     
==========================================
  Files          99       99              
  Lines        7231     7233       +2     
==========================================
+ Hits         6599     6600       +1     
- Misses        632      633       +1     
Impacted Files Coverage Δ
piccolo/query/mixins.py 94.41% <50.00%> (-0.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dantownsend
Copy link
Member

Cool, thanks!

@dantownsend dantownsend merged commit 248c209 into piccolo-orm:master Nov 10, 2022
@MiguelGuthridge MiguelGuthridge deleted the miguel/order-by-error-check branch November 11, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to specify a column when using order_by results in a confusing error
3 participants