Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format the json nicely when dumping fixtures #848

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

sinisaos
Copy link
Member

Related to #847

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Merging #848 (a65d3b0) into master (74ea10d) will decrease coverage by 4.23%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage   91.62%   87.40%   -4.23%     
==========================================
  Files         109      109              
  Lines        7885     7885              
==========================================
- Hits         7225     6892     -333     
- Misses        660      993     +333     
Impacted Files Coverage Δ
piccolo/apps/fixtures/commands/dump.py 51.11% <100.00%> (ø)

... and 30 files with indirect coverage changes

@dantownsend
Copy link
Member

I've tested this, and it works well 👍

@dantownsend dantownsend merged commit 29f4c2f into piccolo-orm:master Jun 20, 2023
46 checks passed
@sinisaos sinisaos deleted the fixtures_formatted_json branch June 20, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants