Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema - indicate that a column is timestamptz #897

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

dantownsend
Copy link
Member

When looking at the JSON schema for a table, we can't distinguish between Timestamp and Timestamptz columns.

This would be useful to know in Piccolo Admin, so we can visually differentiate between timezone-aware timestamps and naive timestamps.

@dantownsend dantownsend added the enhancement New feature or request label Nov 2, 2023
@dantownsend dantownsend added this to In progress in Enhancements via automation Nov 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #897 (d6f9e0d) into master (28fe3a4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #897   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         107      107           
  Lines        8113     8115    +2     
=======================================
+ Hits         7473     7475    +2     
  Misses        640      640           
Files Coverage Δ
piccolo/utils/pydantic.py 96.93% <100.00%> (+0.06%) ⬆️

@dantownsend dantownsend merged commit febe5bb into master Nov 3, 2023
37 checks passed
Enhancements automation moved this from In progress to Done Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants