Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

994 Add support for more functions (upper, lower etc) #996

Merged
merged 42 commits into from
May 29, 2024

Conversation

dantownsend
Copy link
Member

@dantownsend dantownsend commented May 28, 2024

Resolves #994

@dantownsend dantownsend added the enhancement New feature or request label May 28, 2024
@dantownsend dantownsend added this to In progress in Enhancements via automation May 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2024

Codecov Report

Attention: Patch coverage is 82.25806% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 79.33%. Comparing base (919983a) to head (7309a7b).
Report is 6 commits behind head on master.

Files Patch % Lines
piccolo/querystring.py 70.58% 10 Missing ⚠️
piccolo/query/functions/base.py 66.66% 6 Missing ⚠️
piccolo/columns/m2m.py 50.00% 3 Missing ⚠️
piccolo/columns/column_types.py 85.71% 1 Missing ⚠️
piccolo/query/methods/select.py 93.75% 1 Missing ⚠️
piccolo/query/mixins.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #996       +/-   ##
===========================================
- Coverage   92.78%   79.33%   -13.46%     
===========================================
  Files         108      111        +3     
  Lines        8182     8255       +73     
===========================================
- Hits         7592     6549     -1043     
- Misses        590     1706     +1116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend dantownsend changed the title 994 Add support for upper and lower - v2 994 Add support for more functions (upper, lower etc) May 29, 2024
@dantownsend dantownsend marked this pull request as ready for review May 29, 2024 23:39
@dantownsend dantownsend merged commit a85b404 into master May 29, 2024
46 checks passed
Enhancements automation moved this from In progress to Done May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Add support for upper and lower
2 participants