Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Pydantic breaking changes #289

Closed
dantownsend opened this issue Jul 15, 2024 · 2 comments · Fixed by #290
Closed

Fix for Pydantic breaking changes #289

dantownsend opened this issue Jul 15, 2024 · 2 comments · Fixed by #290
Labels
bug Something isn't working

Comments

@dantownsend
Copy link
Member

dantownsend commented Jul 15, 2024 •
edited

It looks like Pydantic changed a parameter name from __model_name to model_name, so it breaks our CI:

piccolo_api/piccolo_api/crud/endpoints.py

Line 380 in 5c2b86f

__model_name=model_name,

Presumably we just have to change it to model_name and version pin Pydantic more tightly.
@dantownsend dantownsend added the bug Something isn't working label Jul 15, 2024
@dantownsend
Copy link
Member Author

Looks like it broke here: pydantic/pydantic#9479

@dantownsend
Copy link
Member Author

It broke in v2.8.0 https://github.com/pydantic/pydantic/releases/tag/v2.8.0

So we need to version pin to this.

@dantownsend dantownsend mentioned this issue Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

289 Fix for Pydantic breaking changes piccolo-orm/piccolo_api
1 participant
@dantownsend