Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/tests #40

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Add/tests #40

merged 3 commits into from
Oct 16, 2022

Conversation

mikebarr24
Copy link
Contributor

Created tests and script for running tests.

dantownsend
dantownsend reviewed Oct 16, 2022
View reviewed changes
e2e/test_homepage.py Outdated Show resolved Hide resolved
@dantownsend
Copy link
Member

@mikebarr24 This is great, thanks! Just some minor comments.

@mikebarr24
Copy link
Contributor Author

mikebarr24 commented Oct 16, 2022 •
edited
Loading

@dantownsend
That should be the requested changes made to the PR. Let me know if that's grand and thanks for the feedback.
I'll get a look at the next part this coming week.

@dantownsend
Copy link
Member

@mikebarr24 This looks great - thanks for making those changes.

@dantownsend dantownsend merged commit be51173 into piccolo-orm:master Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantownsend dantownsend dantownsend left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikebarr24 @dantownsend