Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] New parameter to exclude from useShouldInterceptAjaxRequest sync requests. #1905

Closed
EArminjon opened this issue Dec 6, 2023 · 2 comments

Comments

@EArminjon
Copy link
Contributor

Environment

Flutter version:
Plugin version:
Android version:
iOS version:
Xcode version:
Device information:

Description

What you'd like to happen:

It could be interesting to exclude, from useShouldInterceptAjaxRequest, requests which are sync and not fully supported by the interceptor.

Capture d’écran 2023-12-06 à 18 12 37

If a web function call an ajax sync request and want to return it's result, using useShouldInterceptAjaxRequest will launch an asynchronous call and this web function will just return "undefined". So, useShouldInterceptAjaxRequest will broke some web feature.

Copy link

github-actions bot commented Dec 6, 2023

👋 @EArminjon

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

@EArminjon EArminjon changed the title [Feature Request] [Feature Request] New parameter to exclude from useShouldInterceptAjaxRequest sync requests. Dec 6, 2023
@pichillilorenzo
Copy link
Owner

With the next release, the new setting InAppWebViewSettings.interceptOnlyAsyncAjaxRequests will be available.
It will have true as the default value to not break ajax sync requests.

ps9310 pushed a commit to mayank4741/flutter_inappwebview that referenced this issue Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants