Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IosSafariOptions.presentationStyle affecting only dismiss animation #305

Closed
rokgregoric opened this issue Mar 17, 2020 · 3 comments
Closed

Comments

@rokgregoric
Copy link

Environment

Flutter version: 1.12.13+hotfix.8
Plugin version: 2.1.0+1
Android version:
iOS version:
Xcode version:
Device information:

Description

Expected behavior:
On iOS the presentationStyle of SafariViewController should be the same for presenting/dismissing the controller.

Current behavior:
IosSafariOptions.presentationStyle passed in the initializer have no effect on the presentation but they affect the dismissal.

Steps to reproduce

ChromeSafariBrowser().open(
  url: 'https://google.com',
  options: ChromeSafariBrowserClassOptions()
);

opens/closes this way: https://www.dropbox.com/s/l37aob1amr9by47/no-options.mov?dl=0

ChromeSafariBrowser().open(
  url: 'https://google.com',
  options: ChromeSafariBrowserClassOptions(
    iosSafariOptions: IosSafariOptions(
      presentationStyle: IosWebViewOptionsPresentationStyle.OVER_FULL_SCREEN
    )
  )
);

only affects the dismissal: https://www.dropbox.com/s/vhl0ivgmvz55xli/with-options.mov?dl=0

@ArkeshGKalathiya
Copy link

Same Issue here! Have you found any fix?

@ayush221b
Copy link

I am facing this issue as well, I tried going through the code but couldn't find anything missing @pichillilorenzo can you please look into it once?

@pichillilorenzo
Copy link
Owner

Fixed with new released version 3.1.0 right now!

This was referenced Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants