Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try to open with Chrome if default browser app does not support custom tabs #1233

Conversation

addie9000
Copy link
Contributor

Connection with issue(s)

Resolve issue #1232

Testing and Review Notes

  1. Install browser app which does not support custom tabs such as Sleipnir
    https://play.google.com/store/apps/details?id=jp.co.fenrir.android.sleipnir

  2. Set installed browser as a default browser app by setting app

  3. Try to open URL by ChromeSafariBrowser

  4. Before this fix, cannot open URL
    After this fix, can open URL by Chrome

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@addie9000
Copy link
Contributor Author

If Opera browser is installed, somehow all queries return nothing.

After some research, I found that Chrome developer site's sample code has category setting for query intent. Added this solve the problem somehow. Very weird, but it works.

@pichillilorenzo pichillilorenzo merged commit 89808a2 into pichillilorenzo:master Oct 13, 2022
@pichillilorenzo
Copy link
Owner

Thanks! @all-contributors please add @addie9000 for code

@allcontributors
Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @addie9000! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants