Android - Load client certificate from local storage #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a feature to read a client certificate from local storage.
4 tasks
Try `getFileAsset` first and then `new FileInputStream`
pichillilorenzo
changed the title
|
Thanks! @all-contributors please add @akioyamamoto1977 for code |
|
I've put up a pull request to add @akioyamamoto1977! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a feature to read a client certificate from local storage.
Connection with issue(s)
Resolve issue #1085
The original code supports only loading a client certificate in assets folder.
This customization is to load from local storage tree if the certificate path begins with "/" (full path)
Testing and Review Notes
No screen shot, but only few lines added.
Both localstorage and assets files are tested to be loaded as a client certificate