Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated android.webkit.WebSettings setAppCachePath and setAppCacheEnab… #1307

Closed
wants to merge 1 commit into from

Conversation

VictorUvarov
Copy link

@VictorUvarov VictorUvarov commented Sep 8, 2022

…led to reflect compileSdkVersion 33 changes

WebSettings no longer contains setAppCachePath property as of Android 12 (compileSdkVersion 33)

Connection with issue(s)

Resolve issue #1299

Connected to #1269, #1234, #1223

Testing and Review Notes

Just run the example app to see that it builds on compileSdkVersion 33

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@rshrc
Copy link

rshrc commented Sep 9, 2022

Looks Good!! Should be merged!

@VictorUvarov VictorUvarov changed the title remove android.webkit.WebSettings setAppCachePath and setAppCacheEnab… remove deprecated android.webkit.WebSettings setAppCachePath and setAppCacheEnab… Sep 12, 2022
@pichillilorenzo
Copy link
Owner

Unfortunately, I cannot merge your pull request because it introduces a breaking change.
I used java reflection API to try to call these methods if they exist.

@pichillilorenzo
Copy link
Owner

Released new version 5.4.4 with that fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants