Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InAppLocalhostServer decode assets url when loading them #1657

Merged
merged 2 commits into from Jun 12, 2023
Merged

feat: InAppLocalhostServer decode assets url when loading them #1657

merged 2 commits into from Jun 12, 2023

Conversation

Nirajn2311
Copy link
Contributor

@Nirajn2311 Nirajn2311 commented May 18, 2023

Connection with issue(s)

Closes #1656

Testing and Review Notes

Run the app and access localhost:8080/page 1.html in the webview. It will load up with its contents now.

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@pichillilorenzo pichillilorenzo changed the title feat: decode assets url when loading them feat: InAppLocalhostServer decode assets url when loading them Jun 12, 2023
@pichillilorenzo pichillilorenzo merged commit 7fb030e into pichillilorenzo:master Jun 12, 2023
@Nirajn2311 Nirajn2311 deleted the fix/decode-asset-url branch June 12, 2023 15:36
@pichillilorenzo
Copy link
Owner

@all-contributors please add @Nirajn2311 for code

@allcontributors
Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @Nirajn2311! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset files with whitespace in name are not accessible in localhost server
2 participants