New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: chrome tab open failed due to chrome process not running #1772

Merged

pichillilorenzo merged 1 commit into pichillilorenzo:master from YumengNevix:master

Nov 11, 2023

Contributor

YumengNevix commented Sep 3, 2023

Connection with issue(s)

Resolve issue #1771 #1771

Connected to #???

Testing and Review Notes

Screenshots or Videos

To Do

double check the original issue to confirm it is fully satisfied
add testing notes and screenshots in PR description to help guide reviewers
request the "UX" team perform a design review (if/when applicable)


          fix: chrome tab open failed due to chrome process not running

4c712b6

probot-autolabeler bot added the android label

Owner

pichillilorenzo commented Nov 11, 2023

Thanks! By the way, I think it could be better to use another boolean value instead of setting intialUrl to null to avoid webpage reopen.

pichillilorenzo merged commit 828cc7d into pichillilorenzo:master

Owner

pichillilorenzo commented Nov 11, 2023

@all-contributors please add @YumengNevix for code

allcontributors bot mentioned this pull request

add YumengNevix as a contributor for code #1868

Merged

Contributor

allcontributors bot commented Nov 11, 2023

@pichillilorenzo

I've put up a pull request to add @YumengNevix! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment