Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挜 Fix iPad crash due to missing sourceView #1933

Conversation

michalsrutek
Copy link
Contributor

Connection with issue(s)

Resolve issue #1928

Connected to #1928

Testing and Review Notes

The sourceView was missing. It might also be missing in other places, but I haven't yet got time to check - can be done in future PRs.

Also, the look is not ideal, as it's really narrow - but that's for another PR. The main thing is that this scenario does not cause crashes anymore 馃帀 .

Screenshots or Videos

Simulator Screenshot - iPad Pro (12 9-inch) (6th generation) - 2023-12-20 at 12 11 29

@michalsrutek michalsrutek changed the title Fix iPad crash due to missing sourceView 馃挜 Fix iPad crash due to missing sourceView Dec 21, 2023
@michalsrutek michalsrutek changed the title 馃挜 Fix iPad crash due to missing sourceView 馃挜 Fix iPad crash due to missing sourceView Dec 23, 2023
@michalsrutek
Copy link
Contributor Author

@pichillilorenzo can we get this merged and released? 馃檹

@pichillilorenzo
Copy link
Owner

Thanks for all the pull requests!
I will check them as soon as possible to get them merged 馃憤

@pichillilorenzo pichillilorenzo merged commit 5b42251 into pichillilorenzo:master Dec 23, 2023
@pichillilorenzo
Copy link
Owner

By the way, you can change the presentation style using InAppBrowserSettings.presentationStyle聽property, for example:

settings: InAppBrowserClassSettings(
  browserSettings: InAppBrowserSettings(
      toolbarTopBackgroundColor: Colors.blue,
      presentationStyle: ModalPresentationStyle.PAGE_SHEET),
  webViewSettings: InAppWebViewSettings(
    isInspectable: kDebugMode,
    useShouldOverrideUrlLoading: true,
    useOnLoadResource: true,
  ),
),

@pichillilorenzo
Copy link
Owner

@all-contributors please add @michalsrutek for code

Copy link
Contributor

@pichillilorenzo

I've put up a pull request to add @michalsrutek! 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants