fix(bigint): Use typeof for testing if BigInt exists #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `if (BigInt) { … }` style does not work in browser environments that do not implement BigInt (e.g. Safari <= 13).
A `hasBigInt` flag was added and exported from `util` and uses the format of `typeof BigInt !== ‘undefined’` which should work in all environments. All usage of `BigInt` is now guarded by an equivalent of `if (hasBigInt) {…}` to ensure it’s available before use.
|
@pichillilorenzo Any chance this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
if (BigInt) { … }style does not work in browser environments that do not implement BigInt (e.g. Safari <= 13).A
hasBigIntflag was added and exported fromutiland uses the format oftypeof BigInt !== ‘undefined’which should work in all environments. All usage ofBigIntis now guarded by an equivalent ofif (hasBigInt) {…}to ensure it’s available before use.Connection with issue(s)
Resolve issue #11
Testing and Review Notes
None
To Do
N/A