fix: generify check for “native code” #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks for native code using `endsWith(‘{ [native code] }’)` do not work in Safari when code is packaged using webpack because Safari includs newlines in its native code output.
All native code checks have been centralized to a `isNativeCode` function exported from util and the check now uses a regex that allows for any type of white space.
kdubb
force-pushed
the
fix/native_code_check
branch
from
2c34d2b
to
0b6dbf9
Compare
|
@pichillilorenzo Any chance this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks for native code using
endsWith(‘{ [native code] }’)do not work in Safari when code is packaged using webpack because Safari includs newlines in its native code output.All native code checks have been centralized to a
isNativeCodefunction exported from util and the check now uses a regex that allows for any type of white space.Connection with issue(s)
Resolve issue #13
Testing and Review Notes
As stated in issue, the problem is only exhibited when using Safari JS engine and the code using jackson-js is packaged using webpack.
To Do
N/A