Guiders adjust with window resizing #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to leave this outstanding because there are cases where you do not want the guider to reposition. However, this will still be searchable for people who do want it to reposition. |
|
Thats cool. Also note I added 'myGuider === null || myGuider === undefined' on my branch because myGuider === null was not working in all situations. |
|
Any chance this can be merged into master and allowed to be controlled through a set option? We need this feature but don't want to have to maintain our own branch if possible. EDIT Nevermind it appears that this is now available in the latest version. |
|
Yep, just fyi for anyone reading this ticket: this feature is in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I added some code for my own project that allows the guiders to adjust when the window resizes so I figured I share it with you so that you can add it to the main repository.
I had added this as an issue.