Added working delete function for photos

[sbmsr]

Added working delete function for CPLAssets.

Fixes #239

[Tatsh]

Would definitely like to see this merged. Fix the long lines:

pyicloud/services/photos.py:508:80: E501 line too long (266 > 79 characters)
pyicloud/services/photos.py:510:80: E501 line too long (82 > 79 characters)

[Tatsh]

Also, consider making a way to batch delete. I've been posting with 100 operations at a time with no issue but I figure if you sent thousands of HTTP requests for only 1 operation that's very inefficient and the API will throttle a lot more. Perhaps like a add_to_delete_queue() method (or put this on the service and accept an asset argument) and the photos service would have a deletion queue list. On the service object you could call delete_all_in_queue() or something like that. In that method, make it delete only 100 at a time.

[Tatsh]

For permanent deletion, use "fields":{"isExpunged":{"value":1}}}}]. Maybe accept permanent as a kwarg? Otherwise an expunge() method. Apple only does 200 at a time for this method.

[jrmlhermitte]

worked great for me. can we merge this in soon? @r3ticuli any progress?
we can add more features to it later perhaps?

[sbmsr]

I’ll fix this in the coming hours. And agreed - we can add more to it later.

…

On Dec 10, 2017, at 1:05 PM, Julien Lhermitte ***@***.***> wrote: worked great for me. can we merge this in soon? @r3ticuli <https://github.com/r3ticuli> any progress? we can add more features to it later perhaps? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPZzmInUSsDsguJKUti8Moevh8Jl5QJks5s_B10gaJpZM4QFR3B>.

[sbmsr]

done! waiting for review now.

[chadj]

@torarnv this gets a +1 from me

[jrmlhermitte]

👍 from a user
I deleted all my icloud photos using this:

photos_iter = iter(api.photos.all)
for i, photo in enumerate(photos_iter):
    print(f"Deleting file {photo.filename}")
    photo.delete()

I think I had to run it a few times (because not all files were deleted, probably an apple side bug).
But helped me become apple-free. thanks!