Fix null reference exceptions in MsTest result parsing

picklesdoc · May 28, 2014 · 6854dc2 · 6854dc2
1 parent a96512a
commit 6854dc2
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/Pickles/Pickles/TestFrameworks/MsTestSingleResults.cs b/src/Pickles/Pickles/TestFrameworks/MsTestSingleResults.cs
@@ -4,12 +4,13 @@
 using System.Xml.Linq;
 
 using PicklesDoc.Pickles.ObjectModel;
-using PicklesDoc.Pickles.Parser;
 
 namespace PicklesDoc.Pickles.TestFrameworks
 {
   public class MsTestSingleResults : ITestResults
   {
+    private const string Failed = "failed";
+
     private static readonly XNamespace ns = @"http://microsoft.com/schemas/VisualStudio/TeamTest/2010";
     private readonly XDocument resultsDocument;
 
@@ -44,7 +45,7 @@ private TestResult GetExecutionResult(Guid scenarioExecutionId)
       {
         case "passed":
           return TestResult.Passed;
-        case "failed":
+        case Failed:
           return TestResult.Failed;
         default:
           return TestResult.Inconclusive;
@@ -53,12 +54,14 @@ private TestResult GetExecutionResult(Guid scenarioExecutionId)
 
     private static string ResultOutcomeOf(XElement scenarioResult)
     {
-      return scenarioResult.Attribute("outcome").Value;
+      var outcomeAttribute = scenarioResult.Attribute("outcome");
+      return outcomeAttribute != null ? outcomeAttribute.Value : Failed;
     }
 
     private static Guid ResultExecutionIdOf(XElement unitTestResult)
     {
-      return new Guid(unitTestResult.Attribute("executionId").Value);
+      var executionIdAttribute = unitTestResult.Attribute("executionId");
+      return executionIdAttribute != null ? new Guid(executionIdAttribute.Value) : Guid.Empty;
     }
 
     public TestResult GetExampleResult(ScenarioOutline scenario, string[] exampleValues)