Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed content warning from twitterlib.js #40

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

mayamcdougall
Copy link
Collaborator

This fixes a mixed content warning when using https on the site (as reported here picocms/Pico#514 (comment)). This URL was missed because it was hardcoded into a .js file. Also, the original url at github.com now redirects to github.io, so I had to change that to get it to load over https.

This is just a quick fix to prevent the mixed content warning with minimal effort. Ultimately though, I don't think we even use anything provided by this script on the website, so it could just as easily be removed. As far as I know, it's just a piece of the original theme.

I'm not going to merge this one without feedback. I just thought I'd do the legwork to track it down while it was fresh. 馃槈

@mayamcdougall mayamcdougall changed the title Fix https issue Fix mixed content warning from twitterlib.js Mar 23, 2021
@PhrozenByte
Copy link
Collaborator

Thank you! 馃憤 As of now I think that we can merge this to resolve the mixed content warning. However, I think we should open another issue about removing unneeded bits from the theme 馃槃

@mayamcdougall mayamcdougall merged commit 9ea67ed into picocms:master Mar 23, 2021
@mayamcdougall
Copy link
Collaborator Author

Yeah, I agree.

I've been putting some thought lately into revamping the site a little. Not sure how much or how little I plan to do at the moment though. At the very least, I'm not really happy with some of the old gallery images I made. Things like Contribute and More tiles... and the entirety of the plugins page. It's just not very readable. 馃槖

Idk, the whole site feels a little "stale", for lack of a better word. I think the whole thing could use a refresh, I just don't want to start anything that's too ambitious.

I'd also like to have a conversation at some point about where you'd like to take Pico going forward. Things like long term plans and goals. Are you still interested in and planning improvements for Pico, or are you trying to wind that down and just get it to a "finished" state. Are we interested growing the project? If the "core" is hitting a point where it's more or less feature-complete and finished, should we focus on trying to grow out the Pico ecosystem with plugins and themes? Do we care about making/keeping Pico "competitive" with other solutions or should we just continue to let it fill a niche?

These aren't things I want answered here. Just brainstorming mostly. I'll comment sometime on your long-running picocms/Pico#317 to have a proper discussion. Just some things I've been thinking about.

No matter which way you look at it, I still feel like Pico has a lot of untapped potential, if only more people knew it existed. 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants