Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] CSS variables for label font-weight #79

Closed
dylanvdmerwe opened this issue Dec 23, 2021 · 4 comments
Closed

[Feature request] CSS variables for label font-weight #79

dylanvdmerwe opened this issue Dec 23, 2021 · 4 comments

Comments

@dylanvdmerwe
Copy link

If we have a login page, or general form such as this:
image

It would be great to be able to control the form control font-weights so they stand out a bit more.

image

Currently the labels are using:
image

So if --font-weight is adjusted, all the fonts on the page are changed.

Could we have different kinds of variables for labels on forms to control the weights in pico without having to override styles?
@HerrBertling
Copy link
Contributor

You could even do font-weight: var(--label-font-weight, var(--font-weight)) so that this wouldn't even be a breaking change – the fallback for the label font weight would just™ be what is used right now 😊

@jubishop
Copy link
Contributor

Why not just create the PR?

HerrBertling added a commit to HerrBertling/pico that referenced this issue Dec 25, 2021
@HerrBertling
feat(labels): add optional font weight
4f41b11 
which can be set separately from the standard font weight
to put emphasis on the form labels if needed.

closes picocss#79
HerrBertling added a commit to HerrBertling/pico that referenced this issue Dec 25, 2021
@HerrBertling
chore: build docs + css files
037885f 
refs picocss#79
HerrBertling added a commit to HerrBertling/pico that referenced this issue Dec 25, 2021
@HerrBertling
chore: build docs + css files
66f8591 
refs picocss#79
@HerrBertling HerrBertling mentioned this issue Dec 25, 2021
Merged
@HerrBertling
Copy link
Contributor

Sorry, worked on master initially instead of dev. The last two commits should be the correct ones 🙈

@lucaslarroche
Copy link
Member

Thank you @HerrBertling. I like the addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jubishop @HerrBertling @dylanvdmerwe @lucaslarroche