Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip support directions #211

Merged
merged 12 commits into from
Sep 11, 2022
Merged

Tooltip support directions #211

merged 12 commits into from
Sep 11, 2022

Conversation

wenkm
Copy link
Contributor

@wenkm wenkm commented Jun 21, 2022

Support directions with data-placement property.

Add tooltip examples.

image

#180

@telamon
Copy link

telamon commented Aug 20, 2022

I need this! =)
Have an issue with default placement renders tooltips partially offscreen on narrow displays.

image
using release v1.5.3

@wenkm
Copy link
Contributor Author

wenkm commented Sep 1, 2022

I need this! =) Have an issue with default placement renders tooltips partially offscreen on narrow displays.

image using release v1.5.3

Pure CSS is difficult to implement. It can be solved by line wrapping I think.

@sysmat
Copy link

sysmat commented Sep 1, 2022

  • "@picocss/pico": "^1.5.3"
  • data-placement="bottom" not working

@wenkm
Copy link
Contributor Author

wenkm commented Sep 1, 2022

  • "@picocss/pico": "^1.5.3"
  • data-placement="bottom" not working

The author has not merged this request, so it does not take effect.

@sysmat
Copy link

sysmat commented Sep 1, 2022

@wenkm aha thx, sorry my mistake

@lucaslarroche
Copy link
Member

Closes #180

@lucaslarroche
Copy link
Member

Hi @wenkm,
Thank you for your changes and sorry for the delay.
I greatly appreciate your contribution.

I rebased your branch, made slight changes to the SCSS syntax, changed the documentation formatting (see bellow), and rebuilt the CSS.

Screen Shot 2022-09-11 at 15 07 01

I will merge into dev, and then in the next release quickly.
@sysmat, it's coming 🙂🚀

@lucaslarroche
Copy link
Member

Have an issue with default placement renders tooltips partially offscreen on narrow displays.

@wenkm @sysmat
Yes, I tried again, but I didn't have an elegant solution in pure CSS.

@lucaslarroche lucaslarroche merged commit 8f579ef into picocss:dev Sep 11, 2022
This was referenced Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Tooltip : left/right/bottom directions, dark colors, input elements
5 participants