Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAC] Shown event won't fire for Dialog when called via the ShowModalAsync call #2254

Open
VPKSoft opened this issue Jul 14, 2022 · 1 comment
Labels
Milestone

Comments

@VPKSoft
Copy link

VPKSoft commented Jul 14, 2022

Hi,
I don't seem to get the ShowModalAsync call to fire the Shown event on macOS.

Expected Behavior

A NotImplementedException is thrown.

Actual Behavior

Nothing happens.

Steps to Reproduce the Problem

  1. Use the sample code for the dialog.
  2. Call the await new TestDialog().ShowModalAsync(this); from another control or form.

Code that Demonstrates the Problem

using Eto.Forms;
namespace amp.EtoForms.Forms
{
  public class TestDialog: Dialog
  {
      public TestDialog()
      {
          Shown += TestDialog_Shown;
      }

      private void TestDialog_Shown(object? sender, EventArgs e)
      {
          throw new NotImplementedException();
      }
  }
}

Specifications

  • Version:
  • Platform(s): macOS with the Sdk-styled project. I don't know the what it is using: <Project Sdk="Eto.Forms/2.7.0">.
  • Operating System(s): macOS Catalina v.10.15.7
  • Visual Studio: Visual Studio Community 2022 for Mac Version 17.0.6 (build 4)
  • .NET: 6.0.302

This is not urgent in any way - just thought to report the issue.

Ps. Thanks for the great framework 👍🏻 I have started porting my OSS WinForms projects to Eto.

@VPKSoft VPKSoft changed the title Shown event won't fire for Dialog when called via the ShowModalAsync call [MAC] Shown event won't fire for Dialog when called via the ShowModalAsync call Jul 14, 2022
@cwensley
Copy link
Member

Thanks for reporting the issue! In looking at the code this was certainly an oversight when changing some things around.

@cwensley cwensley added the bug label Jul 26, 2022
@cwensley cwensley added this to the 2.7.x milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants