Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIA still doesn't work #127

Closed
hasumikin opened this issue Jul 31, 2022 · 2 comments · Fixed by #128
Closed

VIA still doesn't work #127

hasumikin opened this issue Jul 31, 2022 · 2 comments · Fixed by #128

Comments

@hasumikin
Copy link
Member

@yswallow
Though I merged #126 yesterday, it still doesn't work well:
https://user-images.githubusercontent.com/8454208/182004500-f7c4f7b5-c3e2-47d0-9e66-88b72d19343d.mp4

It looks like the Remap was almost opening the keymap screen but shut up at the end...
I'm investigating. It also appreciated if you have a look :)

@yswallow
Copy link
Contributor

if(! via_active) { } surrounding tud_hid_report(consumer) was removed while previous merging. So Remap receives Consumer report after reading keymaps finished and then Remap resets.

Please see pull-req #129.

@hasumikin
Copy link
Member Author

Sorry, my bad!!!!!! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants