Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take out Joystick report #152

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Take out Joystick report #152

merged 2 commits into from
Nov 22, 2022

Conversation

yswallow
Copy link
Contributor

Fix #148

  • To work with iPad, split HID interface for Joystick.
  • To work with Mac, send HID report only if the report changed except Joystick report.
  • Additionally, remove BIOS keyboard function because it was not working correctly.

I checked this version works with iPhone 8.

prk_firmware-0.9.18-20221121-a09fbed.uf2.zip

- to work on iPad
- send HID report only if the report changed
- remove BIOS Keyboard function
- Joystick stick and Joystick HAT were not read.
@hasumikin hasumikin merged commit ace6647 into picoruby:master Nov 22, 2022
@hasumikin
Copy link
Member

@yswallow Thank you for the PR.
Unfortunately, it seems shift keys (KC_LSFT and KC_RSFT) cause unintentional inputs.
This video capture shows the phenomenon.
I literally pushed and released only a shift key on the video.
I confirmed this issue with two different keyboards (GPK60-46W and SouthernCross).
I'll continue to investigate though, let me inform you of this issue.

1.-.sakura.2.4.1.2849.2022-11-22.22-07-04.mp4

@hasumikin hasumikin mentioned this pull request Nov 22, 2022
@yswallow
Copy link
Contributor Author

hmm.... It's not happen on Windows10 and Linux on prk_firmware-0.9.18-20221121-a09fbed.uf2.zip above.

And I can't build the newest because rake setup does only showing steep -h. ( rake fails with Command failed with status (2): [ls src/ruby/test/tmp/hal/ > /dev/null 2>&1...]. )

Can you provide that UF2?

@hasumikin
Copy link
Member

@yswallow
Copy link
Contributor Author

OK, it reproduced. It may need some key-types. So my comment above is wrong.

I think this is happened by pointer failure: memories pointed by uint8_t *keyboard_keycodes was overwritten.

static uint8_t *keyboard_keycodes = NULL;

I'll fix it.

@yswallow
Copy link
Contributor Author

Can you build & test this?

https://github.com/yswallow/prk_firmware/tree/fix-152

@hasumikin
Copy link
Member

Will try it tonight, thanks!

@hasumikin
Copy link
Member

@yswallow It is working for me! I'm now asking guys to confirm here #148 (comment)

BTW, I fixed Rakefile and pushed master branch. Try rake when you have time

@yswallow
Copy link
Contributor Author

I did.

rake failed with "cc.host_command not found".

https://github.com/picoruby/mruby-pico-compiler/blob/master/mrbgem.rake#L204

So I removed cc.host_command || on the file, then the rake worked.

@hasumikin
Copy link
Member

@yswallow Sorry for that inconvenience again and again.
I did fix it. Should work this time.
You may need to rake deep_clean once

@yswallow
Copy link
Contributor Author

It works! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work on iPad
2 participants