-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take out Joystick report #152
Conversation
- to work on iPad - send HID report only if the report changed - remove BIOS Keyboard function
- Joystick stick and Joystick HAT were not read.
@yswallow Thank you for the PR. 1.-.sakura.2.4.1.2849.2022-11-22.22-07-04.mp4 |
hmm.... It's not happen on Windows10 and Linux on prk_firmware-0.9.18-20221121-a09fbed.uf2.zip above. And I can't build the newest because Can you provide that UF2? |
@yswallow Let me fix Rakefile... |
OK, it reproduced. It may need some key-types. So my comment above is wrong. I think this is happened by pointer failure: memories pointed by prk_firmware/src/usb_descriptors.c Line 246 in 527f8dc
I'll fix it. |
Can you build & test this? |
Will try it tonight, thanks! |
@yswallow It is working for me! I'm now asking guys to confirm here #148 (comment) BTW, I fixed Rakefile and pushed master branch. Try |
I did.
https://github.com/picoruby/mruby-pico-compiler/blob/master/mrbgem.rake#L204 So I removed |
@yswallow Sorry for that inconvenience again and again. |
It works! Thank you! |
Fix #148
I checked this version works with iPhone 8.
prk_firmware-0.9.18-20221121-a09fbed.uf2.zip