Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile and Rakefile for pico sdk 1.5.0 #164

Merged
merged 1 commit into from
May 1, 2023

Conversation

yujiyokoo
Copy link
Contributor

This fixes the Docker-based build (docker compose run --rm prk rake) issues I encountered in my environment. I use Docker Desktop 4.11.1 on macOS 12.6.3 M1 Pro. I have not tested it in other environments.

  • PICO_SDK_TAG is set to 1.5.0 in Rakefile. Updated in Dockerfile.
  • In my environment, pico-sdk version check fails because git status --branch does not seem to return the tag:
# git status --branch
Not currently on any branch.
nothing to commit, working tree clean

but git describe --tags works:

# git describe --tags
1.5.0

@hasumikin hasumikin merged commit d0bef2d into picoruby:master May 1, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants