-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Bol.com API to v6 #27
Conversation
…Retailer API v6, regenerated client & models
Any update on this? |
Yes, I would like to know the same. Will there be a v6 version on time? Since v5 will be EOL on 01-11-22. |
I am also interested in support for the new API versions. |
According to this link, v5 will be EOL on 01-10-22(!), which is in 9 weeks ... |
I agree, I will be working on a more thorough implementation of V6. I assumed my PR (that passed the PHPUnit tests) would have made it easier for the Picqer team to review. I will be testing this in my own codebase verify everything's working. I haven't used every single endpoint yet in the Retailer API but will come back to this later with a verdict based on my own codebase. :) |
Can we get this merged please? @casperbakker |
@frrrht Thank you for your effort. And sorry for the long wait. I just released version 6. Supported versionsWe want to at least support a supported version of the Bol API, obviously. We ourselves are skipping version 6 and are going straight to version 7 (or maybe 8). But with the versioning of the client it is now problem to support version 6 as well. At Picqer we have thousands of connected partners and we ideally would want to rollout new API versions slowly, as we do with almost every integration. But with the wide range of deprecations in the Bol API and the fast pace of new version numbers, this is not easy to do. Next versionsWith the migration between v4 and v5 we supported both of them at the same time in this client. But that is not a nice solution. If we cannot support multiple versions in the same client, then there is also no need for the namespacing per API version. So we are still not sure how we can best model this client to the Bol API. Maybe a design to support multiple versions next to each other, otherwise we can simplify the name spacing. If anyone has some good suggestions, please let us know in the comments. |
Ik ben afwezig t/m maandag 22 augustus.
Voor dringende zaken kunt u mailen naar: ***@***.*** .
|
This PR was made based on the PHPUnit test results.