Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bol.com API to v6 #27

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Update Bol.com API to v6 #27

merged 6 commits into from
Sep 9, 2022

Conversation

frrrht
Copy link
Contributor

@frrrht frrrht commented Mar 29, 2022

This PR was made based on the PHPUnit test results.

@WoutervanderLoopNL
Copy link
Contributor

Any update on this?

@bartvc
Copy link

bartvc commented Jul 22, 2022

Yes, I would like to know the same. Will there be a v6 version on time? Since v5 will be EOL on 01-11-22.

@bramstroker
Copy link

I am also interested in support for the new API versions.

@appdezign
Copy link

Yes, I would like to know the same. Will there be a v6 version on time? Since v5 will be EOL on 01-11-22.

According to this link, v5 will be EOL on 01-10-22(!), which is in 9 weeks ...
I would really like to know if there will be support for the new versions.

https://partnerplatform.bol.com/nl/hulp-nodig/automatiseren/wat-is-de-retailer-api-lifecycle-precies/

@frrrht
Copy link
Contributor Author

frrrht commented Aug 1, 2022

Yes, I would like to know the same. Will there be a v6 version on time? Since v5 will be EOL on 01-11-22.

According to this link, v5 will be EOL on 01-10-22(!), which is in 9 weeks ... I would really like to know if there will be support for the new versions.

https://partnerplatform.bol.com/nl/hulp-nodig/automatiseren/wat-is-de-retailer-api-lifecycle-precies/

I agree, I will be working on a more thorough implementation of V6. I assumed my PR (that passed the PHPUnit tests) would have made it easier for the Picqer team to review. I will be testing this in my own codebase verify everything's working. I haven't used every single endpoint yet in the Retailer API but will come back to this later with a verdict based on my own codebase. :)

@liamseys
Copy link

Can we get this merged please? @casperbakker

@picqer picqer deleted a comment from bartvc Aug 21, 2022
@picqer picqer deleted a comment from bartvc Aug 21, 2022
@casperbakker casperbakker merged commit dbe6e63 into picqer:main Sep 9, 2022
@casperbakker
Copy link
Member

@frrrht Thank you for your effort. And sorry for the long wait. I just released version 6.

Supported versions

We want to at least support a supported version of the Bol API, obviously. We ourselves are skipping version 6 and are going straight to version 7 (or maybe 8). But with the versioning of the client it is now problem to support version 6 as well.

At Picqer we have thousands of connected partners and we ideally would want to rollout new API versions slowly, as we do with almost every integration. But with the wide range of deprecations in the Bol API and the fast pace of new version numbers, this is not easy to do.

Next versions

With the migration between v4 and v5 we supported both of them at the same time in this client. But that is not a nice solution. If we cannot support multiple versions in the same client, then there is also no need for the namespacing per API version.

So we are still not sure how we can best model this client to the Bol API. Maybe a design to support multiple versions next to each other, otherwise we can simplify the name spacing.

If anyone has some good suggestions, please let us know in the comments.

@bartvc
Copy link

bartvc commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants