Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Support v10 API #31

Merged
merged 5 commits into from
Jun 1, 2023
Merged

DRAFT: Support v10 API #31

merged 5 commits into from
Jun 1, 2023

Conversation

WoutervanderLoopNL
Copy link
Contributor

Its still early.

but we want to support V10 when its coming out, to support pushing invoices to de Bol.com API.

see: nieuwe-werkwijze-voor-aanvragen-en-versturen-van-facturen

note: still early code, not tested (yet)

@internetboekhandel
Copy link

It would be nice if you can implement this, bol is pushing this. From june we are not allowed to standard email the invoices but use this (still in beta!) system.
Keep up the great work!

With regards, Theo

Copy link
Contributor

@robvanaarle robvanaarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left some comments that need to be addressed.

src/OpenApi/ClientGenerator.php Outdated Show resolved Hide resolved
src/OpenApi/ClientGenerator.php Outdated Show resolved Hide resolved
src/OpenApi/ClientGenerator.php Show resolved Hide resolved
src/OpenApi/ClientGenerator.php Outdated Show resolved Hide resolved
@WoutervanderLoopNL
Copy link
Contributor Author

@robvanaarle I updated the api generator.

I still need to merge the v9 and v10 files together because the v10 json does not contain the v9 endpoints, only the new still in beta endpoints.

tried to upload a invoice to bol.com and thats working without any error.

Could you please take a look at it?

as the Newsitem says In juni komt er een nieuw end point voor de Retailer API beschikbaar and Vanaf 25 april is dit al mogelijk via de betaversie van de Retailer API v10
for me its unclear if that invoice endpoint wil be in GA in v10 or will be implemented in v9.

if its v9 I will update the merge back to a v9 feature, otherwise I would like to let this be merged in v10 and tagged with a beta/RC tag. because as of juni bol.com doesnt allow us to email the invoice to the customers.

image

            /** @var \Picqer\BolRetailerV8\Model\ReducedShipment[] $apiShipments */
            $apiShipments = $this->apiCreatorService->getBolRetailerClient()->getShipments(
                null,
                null,
                (string)$salesOrder->getSources()->first()->getRemoteId(),
            );

            $this->apiCreatorService->getBolRetailerClient()->uploadInvoice(
                $tmpFile, 
                $apiShipments[0]->shipmentId,
            );

@robvanaarle robvanaarle changed the base branch from main to v10 June 1, 2023 13:06
@robvanaarle robvanaarle merged commit 3dd4126 into picqer:v10 Jun 1, 2023
6 checks passed
@robvanaarle robvanaarle mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants