New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ${var} to {$var} for php 8.2 #41

Merged

casperbakker merged 1 commit into main from fix-variable-php82

Jan 2, 2024

Member

casperbakker commented Jan 2, 2024

From @jobjen02 #40 (comment):

${variableName} is used alot in the 'src/client.php'. But that will be deprecated soon: https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation Is it possible to replace it with {$variableName} in this merge request? PHP 8.2 is not working because of this. Thanks!

I changed the generator and updated the client.


          Change ${var} to {$var} for php 8.2

b913b10

casperbakker merged commit 452a528 into main

4 checks passed

casperbakker deleted the fix-variable-php82 branch

January 2, 2024 07:34

jobjen02 commented Jan 2, 2024

Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment