Merge pull request #186 from picqer/cleanup

Code cleanup
picqer · Oct 6, 2017 · 573569c · 573569c
2 parents f1682ed + 4567a60
commit 573569c
Show file tree

Hide file tree

Showing 61 changed files with 291 additions and 231 deletions.
diff --git a/src/Picqer/Financials/Exact/Account.php b/src/Picqer/Financials/Exact/Account.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class Account
@@ -249,9 +251,8 @@ class Account extends Model
         'Type',
         'VATLiability',
         'VATNumber',
-        'Website'
+        'Website',
     ];
 
     protected $url = 'crm/Accounts';
-
 }
diff --git a/src/Picqer/Financials/Exact/AccountClassification.php b/src/Picqer/Financials/Exact/AccountClassification.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class AccountClassification

diff --git a/src/Picqer/Financials/Exact/AccountItem.php b/src/Picqer/Financials/Exact/AccountItem.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class AccountItem

diff --git a/src/Picqer/Financials/Exact/Address.php b/src/Picqer/Financials/Exact/Address.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class Address
@@ -62,7 +64,6 @@
  */
 class Address extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -123,5 +124,4 @@ class Address extends Model
     ];
 
     protected $url = 'crm/Addresses';
-
 }
diff --git a/src/Picqer/Financials/Exact/ApiException.php b/src/Picqer/Financials/Exact/ApiException.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class ApiException

diff --git a/src/Picqer/Financials/Exact/BankAccount.php b/src/Picqer/Financials/Exact/BankAccount.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class BankAccount
@@ -31,7 +33,6 @@
  */
 class BankAccount extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -57,9 +58,8 @@ class BankAccount extends Model
         'Modifier',
         'ModifierFullName',
         'Type',
-        'TypeDescription'        
+        'TypeDescription',
     ];
 
     protected $url = 'crm/BankAccounts';
-
 }
diff --git a/src/Picqer/Financials/Exact/BankEntry.php b/src/Picqer/Financials/Exact/BankEntry.php
@@ -29,13 +29,12 @@
  */
 class BankEntry extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
     protected $primaryKey = 'EntryID';
 
-    protected $bankEntryLines = [ ];
+    protected $bankEntryLines = [];
 
     protected $fillable = [
         'EntryID',
@@ -60,12 +59,11 @@ class BankEntry extends Model
 
     public function addItem(array $array)
     {
-        if ( ! isset( $this->attributes['BankEntryLines'] ) || $this->attributes['BankEntryLines'] == null) {
-            $this->attributes['BankEntryLines'] = [ ];
+        if (! isset($this->attributes['BankEntryLines']) || $this->attributes['BankEntryLines'] == null) {
+            $this->attributes['BankEntryLines'] = [];
         }
         $this->attributes['BankEntryLines'][] = $array;
     }
 
     protected $url = 'financialtransaction/BankEntries';
-
 }
diff --git a/src/Picqer/Financials/Exact/BankEntryLine.php b/src/Picqer/Financials/Exact/BankEntryLine.php
@@ -55,7 +55,6 @@
  */
 class BankEntryLine extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -107,5 +106,4 @@ class BankEntryLine extends Model
     ];
 
     protected $url = 'financialtransaction/BankEntryLines';
-
 }
diff --git a/src/Picqer/Financials/Exact/CashEntry.php b/src/Picqer/Financials/Exact/CashEntry.php
@@ -1,10 +1,13 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
+
 /**
-* Class CashEntry
-*
-* @package Picqer\Financials\Exact
-* @see https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=financialtransactionCashEntries
-*
+ * Class CashEntry
+ *
+ * @package Picqer\Financials\Exact
+ * @see https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=financialtransactionCashEntries
+ *
  * @property Guid $EntryID Primary key (read-only)
  * @property Double $ClosingBalanceFC Closing balance in the currency of the transaction
  * @property DateTime $Created Creation date (read-only)
@@ -21,10 +24,8 @@
  * @property Int16 $Status Status: 5 = Rejected, 20 = Open, 50 = Processed (read-only)
  * @property String $StatusDescription Description of Status (read-only)
  */
-
 class CashEntry extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -46,19 +47,17 @@ class CashEntry extends Model
         'Modified',
         'OpeningBalanceFC',
         'Status',
-        'StatusDescription'
+        'StatusDescription',
     ];
 
-
     public function addItem(array $array)
     {
-        if (!isset($this->attributes['CashEntryLines']) || $this->attributes['CashEntryLines'] == null) {
+        if (! isset($this->attributes['CashEntryLines']) || $this->attributes['CashEntryLines'] == null) {
             $this->attributes['CashEntryLines'] = [];
         }
         $this->attributes['CashEntryLines'][] = $array;
     }
 
-
     protected $url = 'financialtransaction/CashEntries';
 }
 
diff --git a/src/Picqer/Financials/Exact/CashEntryLine.php b/src/Picqer/Financials/Exact/CashEntryLine.php
@@ -55,7 +55,6 @@
  */
 class CashEntryLine extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -103,9 +102,8 @@ class CashEntryLine extends Model
         'VATCode',
         'VATCodeDescription',
         'VATPercentage',
-        'VATType'
+        'VATType',
     ];
 
     protected $url = 'financialtransaction/CashEntryLine';
-
 }
diff --git a/src/Picqer/Financials/Exact/Connection.php b/src/Picqer/Financials/Exact/Connection.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 use Exception;
 use GuzzleHttp\Client;
@@ -91,7 +93,6 @@ class Connection
      */
     protected $middleWares = [];
 
-
     /**
     * @var
     */
@@ -145,7 +146,7 @@ public function connect()
     /**
      * @param string $method
      * @param $endpoint
-     * @param null $body
+     * @param mixed $body
      * @param array $params
      * @param array $headers
      * @return Request
@@ -199,6 +200,8 @@ public function get($url, array $params = [], array $headers = [])
         } catch (Exception $e) {
             $this->parseExceptionForErrorMessages($e);
         }
+
+        return null;
     }
 
     /**
@@ -219,6 +222,8 @@ public function post($url, $body)
         } catch (Exception $e) {
             $this->parseExceptionForErrorMessages($e);
         }
+
+        return null;
     }
 
     /**
@@ -239,6 +244,8 @@ public function put($url, $body)
         } catch (Exception $e) {
             $this->parseExceptionForErrorMessages($e);
         }
+
+        return null;
     }
 
     /**
@@ -258,6 +265,8 @@ public function delete($url)
         } catch (Exception $e) {
             $this->parseExceptionForErrorMessages($e);
         }
+
+        return null;
     }
 
     /**
@@ -312,7 +321,6 @@ public function setRefreshToken($refreshToken)
         $this->refreshToken = $refreshToken;
     }
 
-
     /**
      *
      */
@@ -455,7 +463,6 @@ private function acquireAccessToken()
         }
     }
 
-
     private function getDateTimeFromExpires($expires)
     {
         if (!is_numeric($expires)) {
@@ -535,7 +542,6 @@ public function setTokenUpdateCallback($callback) {
         $this->tokenUpdateCallback = $callback;
     }
 
-
     /**
      * Parse the reponse in the Exception to return the Exact error messages
      * @param Exception $e

diff --git a/src/Picqer/Financials/Exact/Contact.php b/src/Picqer/Financials/Exact/Contact.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class Contact
@@ -73,7 +75,6 @@
  */
 class Contact extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -141,7 +142,7 @@ class Contact extends Model
         'SocialSecurityNumber',
         'StartDate',
         'State',
-        'Title'
+        'Title',
     ];
 
     protected $url = 'crm/Contacts';

diff --git a/src/Picqer/Financials/Exact/Costcenter.php b/src/Picqer/Financials/Exact/Costcenter.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class Costcenter
@@ -20,7 +22,6 @@
  */
 class Costcenter extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -35,7 +36,7 @@ class Costcenter extends Model
         'Division',
         'Modified',
         'Modifier',
-        'ModifierFullName'
+        'ModifierFullName',
     ];
 
     protected $url = 'hrm/Costcenters';

diff --git a/src/Picqer/Financials/Exact/DirectDebitMandate.php b/src/Picqer/Financials/Exact/DirectDebitMandate.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class DirectDebitMandate
@@ -20,7 +22,6 @@
  */
 class DirectDebitMandate extends Model
 {
-
     use Query\Findable;
     use Persistance\Storable;
 
@@ -35,10 +36,9 @@ class DirectDebitMandate extends Model
         'PaymentType',
         'Reference',
         'SignatureDate',
-        'Type'
+        'Type',
     ];
 
     protected $url = 'cashflow/DirectDebitMandates';
-
 }
 
diff --git a/src/Picqer/Financials/Exact/Division.php b/src/Picqer/Financials/Exact/Division.php
@@ -1,4 +1,6 @@
-<?php namespace Picqer\Financials\Exact;
+<?php
+
+namespace Picqer\Financials\Exact;
 
 /**
  * Class Division
@@ -30,7 +32,6 @@
  */
 class Division extends Model
 {
-
     use Query\Findable;
 
     protected $primaryKey = 'Code';
@@ -56,9 +57,8 @@ class Division extends Model
         'TaxOfficeNumber',
         'TaxReferenceNumber',
         'VATNumber',
-        'Website'
+        'Website',
     ];
 
     protected $url = 'hrm/Divisions';
-
 }