Fixed some minor typos and inconsistency issues in SubscriptionLine.p…

…hp and SubscriptionType.php. Added some properties to SubscriptionLine.
picqer · Oct 19, 2016 · a5da440 · a5da440
1 parent f2d924e
commit a5da440
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 31 deletions.
diff --git a/src/Picqer/Financials/Exact/SubscriptionLine.php b/src/Picqer/Financials/Exact/SubscriptionLine.php
@@ -1,42 +1,42 @@
 <?php namespace Picqer\Financials\Exact;
 
-use DateTime;
-use Picqer\Financials\Exact\Model;
-use Picqer\Financials\Exact\Persistance\Storable;
-use Picqer\Financials\Exact\Query\Findable;
-
 /**
  * Class SubscriptionLine
  *
  * @package Picqer\Financials\Exact
- * @see https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=subscriptionSubscriptions
+ * @see https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=SubscriptionSubscriptionLines
  *
- * @property Guid $ID Primary Key
+ * @property Guid $ID Primary key
  * @property Double $AmountDC Amount in the default currency of the company
  * @property Double $AmountFC Amount in the currency of the transaction
- * @property String $Costcenter Cost Center
- * @property String $Costunit Cost Unit
+ * @property String $Costcenter Cost center
+ * @property String $Costunit Cost unit
  * @property String $Description Description
- * @property String $Discount Discount
+ * @property Double $Discount Discount percentage
+ * @property Int32 $Division Division code
  * @property Guid $EntryID Entry ID
  * @property DateTime $FromDate From date
  * @property Guid $Item Reference to Item
- * @property Int $LineNumber Line number
- * @property Int $LineType Line Type
- * @property Double $NetPrice Net Price in the currency of the transaction
+ * @property String $ItemDescription Description of Item
+ * @property Int32 $LineNumber Line number
+ * @property Int16 $LineType Reference to LineType
+ * @property String $LineTypeDescription Description of LineType
+ * @property Double $NetPrice Net price in the currency of the transaction
  * @property String $Notes Remarks
  * @property Double $Quantity Quantity
  * @property DateTime $ToDate To date
  * @property String $UnitCode Unit code
+ * @property String $UnitDescription Description of Unit
  * @property Double $UnitPrice Unit price in the currency of the transaction (price * unit factor)
  * @property Double $VATAmountFC Vat Amount in the currency of the transaction
  * @property String $VATCode VATCode
+ * @property String $VATCodeDescription Description of VATCode
  */
 class SubscriptionLine extends Model
 {
 
-    use Findable;
-    use Storable;
+    use Query\Findable;
+    use Persistance\Storable;
 
     protected $fillable = [
         'ID',
@@ -46,20 +46,26 @@ class SubscriptionLine extends Model
         'Costunit',
         'Description',
         'Discount',
+        'Division',
         'EntryID',
         'FromDate',
         'Item',
+        'ItemDescription',
         'LineNumber',
         'LineType',
+        'LineTypeDescription',
         'NetPrice',
         'Notes',
         'Quantity',
         'ToDate',
         'UnitCode',
+        'UnitDescription',
         'UnitPrice',
-        'VATAmountFc',
-        'VATCode'
+        'VATAmountFC',
+        'VATCode',
+        'VATCodeDescription',
     ];
 
     protected $url = 'subscription/SubscriptionLines';
-}
+
+}
diff --git a/src/Picqer/Financials/Exact/SubscriptionType.php b/src/Picqer/Financials/Exact/SubscriptionType.php
@@ -1,32 +1,27 @@
 <?php namespace Picqer\Financials\Exact;
 
-use DateTime;
-use Picqer\Financials\Exact\Model;
-use Picqer\Financials\Exact\Persistance\Storable;
-use Picqer\Financials\Exact\Query\Findable;
-
 /**
  * Class SubscriptionType
  *
  * @package Picqer\Financials\Exact
- * @see https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=subscriptionSubscriptions
+ * @see https://start.exactonline.nl/docs/HlpRestAPIResourcesDetails.aspx?name=SubscriptionSubscriptionTypes
  *
- * @property Guid $ID Primary Key
+ * @property Guid $ID Primary key
  * @property String $Code Code
  * @property DateTime $Created Creation date
- * @property Guid $Creator UserID of the Creator
+ * @property Guid $Creator User ID of the creator
  * @property String $CreatorFullName Name of the creator
  * @property String $Description Description
- * @property Int $Division Division Code
+ * @property Int32 $Division Division code
  * @property DateTime $Modified Last modified date
  * @property Guid $Modifier User ID of the last modifier
  * @property String $ModifierFullName Name of the last modifier
  */
 class SubscriptionType extends Model
 {
 
-    use Findable;
-    use Storable;
+    use Query\Findable;
+    use Persistance\Storable;
 
     protected $fillable = [
         'ID',
@@ -38,8 +33,9 @@ class SubscriptionType extends Model
         'Division',
         'Modified',
         'Modifier',
-        'ModifierFullName'
+        'ModifierFullName',
     ];
 
     protected $url = 'subscription/SubscriptionTypes';
-}
+
+}