Allow find on 'Code' id #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephangroen
requested changes
Sep 18, 2017
| @@ -5,8 +5,14 @@ | |||
|
|
|||
| public function find($id) | |||
| { | |||
| if ($this->primaryKey === 'Code') { | |||
There was a problem hiding this comment.
Thank you.
It's a little nicer to change it to not use an else statement. This way it has a clear default.
$filter = $this->primaryKey . " eq guid'$id'";
if ($this->primaryKey === 'Code') {
$filter = $this->primaryKey . " eq $id";
}
|
No problem, I pushed the improved version. Thanks for the great work on the library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some objects, such as Divisions use an integer ID, instead of the more common GUID. To do a filter on ID the syntax in the Exact API is slighty different:
Code eq 5versus
EntryId eq guid'1a2b3c...'This PR allows doing a find() on both types of ID.
Example:
$division = (new Division($connection))->find($me->CurrentDivision);