Fix PHPDoc properties

[ruudk]

PHPStan doesn't like it:

  292    Access to offset 'results' on an unknown class Picqer\Financials\Exact\SalesEntryLines.
  310    Access to offset 'results' on an unknown class Picqer\Financials\Exact\PurchaseEntryLines.

It would be great if you could run PHPStan on this project. It finds a lot more issues like this and it will improve this library 💪

[DannyvdSluijs]

Thanks @ruudk
I've already done quite some work on this but could use all the help. PHPStan is a powerful tool and besides the incorrect phpdoc there are some architectural issues.Didn't get started on them yet as i believe having a complete and correct phpdoc will result in better code due to correct IDE code completion.

Some related pull requests can be found here: https://github.com/picqer/exact-php-client/pulls?q=is%3Apr+author%3ADannyvdSluijs+is%3Aclosed

[ruudk]

Can this be merged?

[DannyvdSluijs]

I'm not the maintainer. Only a heavy user of the package which makes it that I started to help on adding these small fixes. @stephangroen typically seems to do this when there is a few PR's than can be merged and released into a new version.

[stephangroen]

I'll look in to running phpstan for the project. Need to find some time but I will add it to my todo list. I also think it would improve the library.

besides the incorrect phpdoc there are some architectural issues

I want to review the whole library for a next major version. Some things have grown and have gotten a bit ugly, there have been some good comments by users and the architecture in general isn't that great.

[DannyvdSluijs]

@stephangroen leg me know of you want some help. Ive been using the tool quite some time now. Will take you 10 minutes to get it running using docker.
Or I can provide you the output for you to check.