New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The library will loop for ever if string, zero or negative value provided for pharmacode 2 #118

Closed

samymassoud opened this issue Dec 24, 2020 · 1 comment

samymassoud commented Dec 24, 2020

Hi, when the code 0 or less than 0 passed to pharmacode 2 the library will loop forever because there is no validation on the accepted input

casperbakker added a commit that referenced this issue


          Fix generating Pharmacode 2 with invalid input #118

2221d83

Member

casperbakker commented Dec 24, 2020

Thanks @samymassoud. I fixed it with throwing a InvalidLengthException in that case. At least the process is not running forever.

casperbakker closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment