New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a PID for LilyGO T-Display rp2040 #827
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3568667
create listing of LilyGO for T-Display rp2040
kreier 7ccba8e
linked layout and schematics of T-Display on github
kreier 73aecbd
Merge branch 'pidcodes:master' into master
kreier 8c57f31
Merge branch 'pidcodes:master' into master
kreier bdc26e4
Create index.md for SSIS Robotics
kreier 67acc8e
Delete index.md
kreier 19a1d90
updated to match organization description
kreier File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| layout: pid | ||
| title: T-Display rp2040 | ||
| owner: LilyGO | ||
| license: MIT | ||
| site: https://github.com/Xinyuan-LilyGO/LILYGO-T-display-RP2040 | ||
| source: https://github.com/Xinyuan-LilyGO/LILYGO-T-display-RP2040 | ||
| --- | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| layout: org | ||
| title: LilyGO | ||
| site: http://www.lilygo.cc/ | ||
| --- | ||
| LILYGO® is a company integrating R&D, production, and sales and committed to promoting the development of the industry for IoT. | ||
| "Dedicated to the development of the IOT. Making development become easier" is the product concept of LILYGO® | ||
|
|
||
| taken from: https://www.lilygo.cc/pages/about-us | ||
|
|
||
| Address: | ||
| Shenzhen Xin Yuan Electronic Technology Co., Ltd | ||
| 401 4F Bldg. building B. No.5 | ||
| 1st Rd Bantianshangxue Technology Park | ||
| Bantian St, Longgang Dist., Shenzhen Guangdong China | ||
|
|
||
| 深圳市龙岗区坂田街道稼先路2000号有所为大厦A栋 | ||
| from: http://www.lilygo.cn/contact.aspx?TypeId=13&FId=t7:13:7 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind having yourself as the owner and link to the fork of CircuitPython with the changes? I want it to be clear that this isn't for LilyGo. It is for a third party using their hardware. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kreier Awaiting your changes as requested by @tannewt. Then we can proceed with the board PR. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannewt sure, no problem. Yet I have a lot of options and possible answers, maybe you can point to the best one. Following the instructions on https://pid.codes/howto/ I have
2. Set up your organization page
a) I keep org/LilyGO/index.md
b) I create a new page for myself as org/kreier/index.md , linking to https://kreier.org
c) I create one for our school club org/SSISRobotics/index.md and link to https://github.com/ssis-robotics
3. Find a VID and PID - 1209/2023/index.md
a) Keep the title in 1209/2023/index.md
b) Change title to 'SSIS:bit with T-Display rp2040' in reference to my older project https://github.com/ssisbit/ssis.bit
c) Change the owner to Matthias Kreier
d) Change the site to adafruit/circuitpython#6037
e) Keep the source with https://github.com/Xinyuan-LilyGO/LILYGO-T-display-RP2040
f) Change the source to https://github.com/kreier/t-display where I collect ideas since 2020
g) Change the title to 'SSIS.bit with T-Display rp2040' and reference https://github.com/ssis-robotics/ssis.bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannewt any update on @kreier 's outstanding questions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b or c is fine. Whichever you'd like.
The title can be the same but I'd switch the site to the CP PR. Please change the owner to match 2.
My main goal is to not give the impression that the manufacturer of the closed source board was granted a PID.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannewt Thanks for the feedback, that's a good solution to make a proper use of the pidcodes project. I updated both the organization description (LilyGO is out and a new SSIS-Robotics in) and the 1209/2023/index.md. I left the title as T-Display rp2040 since the organization name will be prefixed in the final list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: Thanks for volunteering to run this project. Please don't burn out. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kreier First of all thanks for get this through. Do you mind if I add a PID request for the T-Display PICOC3 board under your org "SSS Robotics" just like the T-Display RP2040 so I can try to contribute the board definition to CircuitPython as well. That board has wifi build-in should be able to power some very interesting project. Or if you have other suggestion for obtain a official PID?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @erongd , sure, no problem. You can copy the SSIS Robotics information for another PID request. Let's see if that is necessary. I think you should be able to use the same PID for the PicoC3 (depending how you plug in the USB-C cable) since in one side it's a regular T-Display rp2040 (only 2 serial pins connected to another onboard MCU) and the other way it is covered by Espressif - and not relevant for us, since we won't use it for CircuitPython on the ESP32 C3.