Added WithProgressIncrements extension methods #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rained control over the number of transaction commits/updates being performed especially with loops > 1000 iterations, as this will result in 1000 tx commits. On low resource cloud computing instances this can lead to Hangfire not getting heartbeat response within timeout, causing jobs to be abandoned and restarted.
| { | ||
| _enumerator = enumerator; | ||
| _progressBar = progressBar; | ||
| _count = count; | ||
| _index = -1; | ||
| _percentageIncrementStep = percentageIncrementStep; | ||
| _segmentThreshold = (int)((_percentageIncrementStep / 100.0) * _count); |
There was a problem hiding this comment.
It is incorrect to pre-calc it here, as _count may change during enumeration
There was a problem hiding this comment.
Good point, will add to the PR.
| { | ||
| _enumerator = enumerator; | ||
| _progressBar = progressBar; | ||
| _count = count; | ||
| _index = -1; | ||
| _percentageIncrementStep = percentageIncrementStep; | ||
| _segmentThreshold = (int)((_percentageIncrementStep / 100.0) * _count); |
There was a problem hiding this comment.
It is incorrect to pre-calc it here, as _count may change during enumeration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to allow more course grained control over the number of transaction commits/updates being performed especially with loops > 1000 iterations, as this will result in 1000 (100/0.1 percentage steps) tx commits. On low resource (1 core, SQL Express) cloud computing instances this can lead to Hangfire not getting the heartbeat response within timeout, causing jobs to be abandoned and restarted.