Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piece_mesh() no longer works with {rayvertex} v0.10.3 #339

Closed
trevorld opened this issue Dec 12, 2023 · 2 comments
Closed

piece_mesh() no longer works with {rayvertex} v0.10.3 #339

trevorld opened this issue Dec 12, 2023 · 2 comments
Assignees
Labels
bug Something isn't working external Upstream bug

Comments

@trevorld
Copy link
Member

Prof. Ripley writes:

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_piecepackr.html.

Please correct before 2023-12-26 to safely retain your package on CRAN.

Do remember to look at the 'Additional issues'.

The CRAN Team

This appears to be due to a possible regression in {rayvertex}: tylermorganwall/rayvertex#16

@trevorld trevorld added bug Something isn't working external Upstream bug labels Dec 12, 2023
@trevorld trevorld self-assigned this Dec 12, 2023
@tylermorganwall
Copy link

rayvertex has been updated on the CRAN

@trevorld
Copy link
Member Author

rayvertex has been updated on the CRAN

Thanks! It looks like the "donttest" Additional issue has already disappeared from my CRAN check results page.

To be double safe I'll bump the required version number for {rayvertex} in the DESCRIPTION and release an updated version of {piecepackr} to CRAN soon (NB. CRAN submission is closed from Dec. 22 due to holiday break). We'll eliminate the new #337 NOTE as well.

trevorld added a commit that referenced this issue Dec 17, 2023
* Bumps version of `{rayvertex}` in the `DESCRIPTION` to v0.10.4 to avoid a bug
  introduced in v0.10.3 that affected `piece_mesh()` (#339).

closes #339, closes #306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external Upstream bug
Projects
None yet
Development

No branches or pull requests

2 participants