Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack #16

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Webpack #16

merged 2 commits into from
Oct 13, 2020

Conversation

piecioshka
Copy link
Owner

@piecioshka piecioshka commented Oct 13, 2020 •
edited
Loading

Webpack is added because we don't cover exports in tests, so Coveralls throw an error:

Screenshot 2020-10-14 at 00 03 20

@piecioshka piecioshka added the enhancement New feature or request label Oct 13, 2020
@piecioshka piecioshka self-assigned this Oct 13, 2020
@coveralls
Copy link

coveralls commented Oct 13, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 70

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.3%) to 100.0%
Totals Coverage Status
Change from base Build 54: 5.3%
Covered Lines: 124
Relevant Lines: 124
💛 - Coveralls

@piecioshka piecioshka merged commit 3abe098 into master Oct 13, 2020
@piecioshka piecioshka deleted the feature/webpack branch October 13, 2020 22:21
piecioshka added a commit that referenced this pull request Oct 13, 2020
@piecioshka
Merge branch 'master' into feature/header-with-sorting
afc5fd0 
* master:
  Webpack (#16)
  UT: Duplicates listeners
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piecioshka piecioshka

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piecioshka @coveralls