[fix] closes xbmc#13533. This eliminates a control lookup that result…

…s in an exception when the particular control isn't a known python control type.
pieh · Nov 11, 2012 · 39af2a1 · 39af2a1
1 parent 33c04d0
commit 39af2a1
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/xbmc/interfaces/legacy/WindowXML.cpp b/xbmc/interfaces/legacy/WindowXML.cpp
@@ -377,12 +377,8 @@ namespace XBMCAddon
             {
               if ((controlClicked->IsContainer() && (message.GetParam1() == ACTION_SELECT_ITEM || message.GetParam1() == ACTION_MOUSE_LEFT_CLICK)) || !controlClicked->IsContainer())
               {
-                AddonClass::Ref<Control> inf(GetControlById(iControl));
-                if (inf.isNotNull())
-                {
-                  invokeCallback(new CallbackFunction<WindowXML,int>(this,&WindowXML::onClick,iControl));
-                  PulseActionEvent();
-                }
+                invokeCallback(new CallbackFunction<WindowXML,int>(this,&WindowXML::onClick,iControl));
+                PulseActionEvent();
                 return true;
               }
               else if (controlClicked->IsContainer() && message.GetParam1() == ACTION_MOUSE_RIGHT_CLICK)