Resume video when view is visible (closes #31) Remove warnings in Xcode 7.3 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jyxia
commented
Mar 24, 2016
jyxia
commented
- Removed selector warnings in Xcode 7.3. e.g. "Use of string literal for Objective-C is deprecated..."
- Fixes bug Ability to resume video when the view is visible #31, made the player resumes playing when view is re-visible.
…s in Xcode 7.3 1. Removed selector warnings in Xcode 7.3. e.g. "Use of string literal for Objective-C is deprecated..." 2. Fixes bug piemonte#31, made the player resumes playing when view is re-visible.
|
@piemonte any chance you can review/merge this please? |
|
@mikekhristo indeed, changes look good. thanks for the contributions @jyxia ✌️ |
|
@piemonte You are welcome. I love your work. If there is no problem, maybe you can accept my pull request and merge it. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.